zpinto opened a new pull request, #2801: URL: https://github.com/apache/helix/pull/2801
### Issues - [x] Deprecate HELIX_DISABLED_REASON, as we will no longer be using the HELIX_ENABLED field and this reason field is too specific to HELIX_ENABLED. - [x] Add a new type of REASON that can be associated with setting InstanceOperation to DISABLE or UNKNOWN - [x] Migrate any references to HELIX_DISABLED_REASON to new reason ### Description Deprecate HELIX_DISABLED_REASON and add NON_SERVING_INSTANCE_OPERATION_REASON to be used when setting InstanceOperation to DISABLE or UNKNOWN. ### Tests - [x] Added TestInstanceConfig#testInstanceNonServingReason - [x] Added TestZkHelixAdmin#testSetInstanceOperation ### Changes that Break Backward Compatibility (Optional) - This change is backwards compatible with HELIX_DISABLED_REASON. ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
