zpinto commented on code in PR #2801:
URL: https://github.com/apache/helix/pull/2801#discussion_r1614063969
##########
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java:
##########
@@ -358,10 +357,10 @@ private boolean
validateInstancesUnableToAcceptOnlineReplicasLimit(final Resourc
if (maxInstancesUnableToAcceptOnlineReplicas >= 0) {
// Instead of only checking the offline instances, we consider how many
instances in the cluster
// are not assignable and live. This is because some instances may be
online but have an unassignable
- // InstanceOperation such as EVACUATE, DISABLE, or UNKNOWN. We will
exclude SWAP_IN instances from
+ // InstanceOperation such as EVACUATE, and DISABLE. We will exclude
SWAP_IN and UNKNOWN instances from
// they should not account against the capacity of the cluster.
int instancesUnableToAcceptOnlineReplicas =
cache.getInstanceConfigMap().entrySet().stream()
Review Comment:
Not relevant with latest updates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
