zpinto commented on code in PR #2801:
URL: https://github.com/apache/helix/pull/2801#discussion_r1614064711
##########
helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java:
##########
@@ -48,9 +48,13 @@ public class InstanceConfig extends HelixProperty {
* Configurable characteristics of an instance
*/
public enum InstanceConfigProperty {
- HELIX_HOST, HELIX_PORT, HELIX_ZONE_ID, @Deprecated
+ HELIX_HOST,
+ HELIX_PORT,
+ HELIX_ZONE_ID,
+ @Deprecated
HELIX_ENABLED,
HELIX_ENABLED_TIMESTAMP,
Review Comment:
I think we should still keep HELIX_ENABLED_TIMESTAMP so re-enabling or
disabling it when it is already in that state does not reset the delay window.
Let's discuss this more offline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
