jacob-netguardians commented on code in PR #2977: URL: https://github.com/apache/helix/pull/2977#discussion_r1876129555
########## helix-core/src/main/java/org/apache/helix/controller/pipeline/AbstractBaseStage.java: ########## @@ -64,9 +65,9 @@ public String getStageName() { return className; } - public static <T> Future asyncExecute(ExecutorService service, Callable<T> task) { + public static <T> Future<T> asyncExecute(ExecutorService service, Callable<T> task) { Review Comment: Ok, I now understood what you mean. I applied the reformatting to all files I touched within the change ########## helix-core/src/main/java/org/apache/helix/controller/pipeline/AbstractBaseStage.java: ########## @@ -64,9 +65,9 @@ public String getStageName() { return className; } - public static <T> Future asyncExecute(ExecutorService service, Callable<T> task) { + public static <T> Future<T> asyncExecute(ExecutorService service, Callable<T> task) { Review Comment: Ok, I now understood what you mean. I applied the reformatting to all files I touched within the change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org