laxman-ch commented on code in PR #3052: URL: https://github.com/apache/helix/pull/3052#discussion_r2174269064
########## helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerStateModel.java: ########## @@ -40,6 +40,9 @@ public class DistClusterControllerStateModel extends AbstractHelixLeaderStandbyS protected Optional<HelixManager> _controllerOpt = Optional.empty(); Review Comment: Given we are reinstantiating this in multiple threads, its recommended to make this volatile to prevent processor using the stale reference from the cache. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
