LZD-PratyushBhatt commented on code in PR #3052:
URL: https://github.com/apache/helix/pull/3052#discussion_r2191395133
##########
helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerStateModel.java:
##########
@@ -62,7 +65,7 @@ public void onBecomeLeaderFromStandby(Message message,
NotificationContext conte
logger.info(controllerName + " becoming leader from standby for " +
clusterName);
- synchronized (_controllerOpt) {
+ synchronized (_controllerLock) {
Review Comment:
Let me know what you think, if we are sure this class will be small in size
in future and not much complex, then yeah synchronized methods make more sense
then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
