junkaixue commented on code in PR #3052:
URL: https://github.com/apache/helix/pull/3052#discussion_r2191133757
##########
helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerStateModel.java:
##########
@@ -62,7 +65,7 @@ public void onBecomeLeaderFromStandby(Message message,
NotificationContext conte
logger.info(controllerName + " becoming leader from standby for " +
clusterName);
- synchronized (_controllerOpt) {
+ synchronized (_controllerLock) {
Review Comment:
If Optional.empty() is the root cause of locking problem, why not just make
the function synchronized without creating new lock object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
