Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8593 )
Change subject: IMPALA-6092: avoid drop/create function interactions in e2e tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8593/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8593/1//COMMIT_MSG@10 PS1, Line 10: IMPALA-6215 explains a race between the lib_cache > Absolutely we should fix 6215, but we should also avoid unspecified test in IMO, this is not an "inadvertent interaction". I'm pretty sure many users use the UDFs this way (have a single source fat jar and reference it across multiple functions/queries/DDLs). My feeling is that the way this e-e test case is written, it provides test coverage for that use case scenario and I feel we shouldn't change that. I'm not too strong about this, but may be better to check with Dimitris/Alex too. -- To view, visit http://gerrit.cloudera.org:8080/8593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica3538788b1d2ab5e361261e2ade62780b838e65 Gerrit-Change-Number: 8593 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 20 Nov 2017 18:36:54 +0000 Gerrit-HasComments: Yes
