Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8593 )
Change subject: IMPALA-6092: avoid drop/create function interactions in e2e tests ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8593/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8593/1//COMMIT_MSG@13 PS1, Line 13: test_udf_invalid_symbol drops a function from that jar, which causes the use > nit: line overflow in multiple places. Done http://gerrit.cloudera.org:8080/#/c/8593/1/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: http://gerrit.cloudera.org:8080/#/c/8593/1/tests/query_test/test_udfs.py@422 PS1, Line 422: check_call(["hadoop", "fs", "-put", "-f", src_udf_path, tgt_udf_path]) > Just to be sure, this works ok on local fs right? Basically we "put" from l Couple of points. This always copies from a local source and it renames to a unique tgt name in local fs. Its also the way that the create/drop tests are also setup (they're careful not to use the same shared jar across tests). I assume the other tests work, but just in case-- how do I run just the local fs version of the test to verify this? -- To view, visit http://gerrit.cloudera.org:8080/8593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica3538788b1d2ab5e361261e2ade62780b838e65 Gerrit-Change-Number: 8593 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Mon, 20 Nov 2017 20:22:18 +0000 Gerrit-HasComments: Yes