Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8593 )
Change subject: IMPALA-6092: avoid drop/create function interactions in e2e tests ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8593/2/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: http://gerrit.cloudera.org:8080/#/c/8593/2/tests/query_test/test_udfs.py@422 PS2, Line 422: check_call(["hadoop", "fs", "-put", "-f", src_udf_path, tgt_udf_path]) > if the test fails partway through, will this file get deleted somehow or wi it does get left around (as with the other tests). perhaps a better pattern here is to put these in a dir and use the tester's teardown method to cleanup. not sure how many other places follow the current pattern. -- To view, visit http://gerrit.cloudera.org:8080/8593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica3538788b1d2ab5e361261e2ade62780b838e65 Gerrit-Change-Number: 8593 Gerrit-PatchSet: 2 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2017 19:15:16 +0000 Gerrit-HasComments: Yes
