Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 )
Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Please add a test as Phil suggested. If we decide to add 64-bit timestamps to the profile, please file a JIRA for it. http://gerrit.cloudera.org:8080/#/c/8611/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/8611/2/be/src/service/client-request-state.cc@110 PS2, Line 110: summary_profile_->AddInfoString("Start Time", ToStringFromUnixMicros(start_time_us(), : TimePrecision::Nanosecond)); Please add a comment as to why we use nano-second here: Some management software may rely on parsing the "Start Time" and "End Time" to derive duration and other metrics. To avoid breaking compatibility, keep to nano-seconds for timestamp string for now. TODO: Provide 64-bit timestamp for start and end time in nano-second so consumers of profiles can derive it properly. -- To view, visit http://gerrit.cloudera.org:8080/8611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0 Gerrit-Change-Number: 8611 Gerrit-PatchSet: 2 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Tue, 21 Nov 2017 01:15:50 +0000 Gerrit-HasComments: Yes
