Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 )
Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/8611/4/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/8611/4/tests/query_test/test_observability.py@116 PS4, Line 116: nanosecond precision.""" I think this needs a bit more explanation as to why nanoseconds precision is currently required. http://gerrit.cloudera.org:8080/#/c/8611/4/tests/query_test/test_observability.py@129 PS4, Line 129: query_profile should that be query_profile_encoded? seems like that's the one that would be more likely polled by management tools, but I'm not 100% sure. http://gerrit.cloudera.org:8080/#/c/8611/4/tests/query_test/test_observability.py@130 PS4, Line 130: if len(profile_page) < 100: so i guess the internval/timeout for read_debug_webpage() isn't sufficient in this case since the profile page may not show the full profile at first? Instead of using the length as a hint, maybe we should just keep poling until start_time/end_time shows up? -- To view, visit http://gerrit.cloudera.org:8080/8611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0 Gerrit-Change-Number: 8611 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2017 22:09:08 +0000 Gerrit-HasComments: Yes
