Hello Michael Ho, Philip Zeyliger, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8611
to look at the new patch set (#4).
Change subject: IMPALA-6225: Query profile date-time strings should have ns
precision.
......................................................................
IMPALA-6225: Query profile date-time strings should have ns precision.
IMPALA-5599 changed the precision of query start and end time date-time
string representations to microseconds. This ended up breaking
compatibility with some API clients.
This patch restores the precision to nanosecond, even though the
timestamps themselves have only microsecond precision. Effectively,
what we end up doing is to zero-pad the fractional second part to
nine decimal places.
I have manually checked from the Impala debug web page that the start
and end times of queries have nanosecond precision:
Start Time: 2017-11-20 14:59:01.954031000
End Time: 2017-11-20 15:00:02.103735000
This is basically the same as how it was before. The following is taken
from a cluster running Impala 2.11:
Start Time: 2017-11-20 14:17:52.198270000
End Time: 2017-11-20 14:18:52.242868000
Also added TestObservability::test_query_profile_timestamps test case.
Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0
---
M be/src/service/client-request-state.cc
M be/src/service/impala-http-handler.cc
M be/src/util/time.h
M tests/query_test/test_observability.py
4 files changed, 52 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/8611/4
--
To view, visit http://gerrit.cloudera.org:8080/8611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0
Gerrit-Change-Number: 8611
Gerrit-PatchSet: 4
Gerrit-Owner: Zoram Thanga <zo...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
