Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 )
Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected() ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/data-stream-mgr.cc File be/src/runtime/data-stream-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/data-stream-mgr.cc@273 PS1, Line 273: return Status(err.str()); Is this one useful? http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc File be/src/runtime/krpc-data-stream-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc@201 PS1, Line 201: ErrorMsg msg(TErrorCode::DATASTREAM_RECVR_CLOSED, PrintId(finst_id), dest_node_id); Should we log the msg.msg()? http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc@309 PS1, Line 309: return Status(msg); same. -- To view, visit http://gerrit.cloudera.org:8080/8689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad Gerrit-Change-Number: 8689 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Comment-Date: Wed, 29 Nov 2017 23:06:00 +0000 Gerrit-HasComments: Yes
