Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 )
Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc File be/src/runtime/krpc-data-stream-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc@201 PS1, Line 201: ErrorMsg msg(TErrorCode::DATASTREAM_RECVR_CLOSED, PrintId(finst_id), dest_node_id); > Not really as this doesn't provide much information. We need to propagate a why doesn't the same argument hold in the non-krpc case. (I don't feel too strongly so okay to leave it alone but curious). -- To view, visit http://gerrit.cloudera.org:8080/8689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad Gerrit-Change-Number: 8689 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Thu, 30 Nov 2017 18:42:30 +0000 Gerrit-HasComments: Yes
