Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 )
Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected() ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/data-stream-mgr.cc File be/src/runtime/data-stream-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/data-stream-mgr.cc@273 PS1, Line 273: return Status(err.str()); > Is this one useful? This is very unlikely to occur even under load. This is more likely due to a logical error in the code IMHO so I leave it as Status for now. http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc File be/src/runtime/krpc-data-stream-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc@201 PS1, Line 201: ErrorMsg msg(TErrorCode::DATASTREAM_RECVR_CLOSED, PrintId(finst_id), dest_node_id); > Should we log the msg.msg()? Not really as this doesn't provide much information. We need to propagate an error status to the sender to alleviate the issue described in IMPALA-3990. http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc@309 PS1, Line 309: return Status(msg); > same. This is very unlikely to occur even under load. This is more likely due to a logical error in the code IMHO so I leave it as Status for now. -- To view, visit http://gerrit.cloudera.org:8080/8689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad Gerrit-Change-Number: 8689 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Wed, 29 Nov 2017 23:19:57 +0000 Gerrit-HasComments: Yes
