Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8754
Change subject: IMPALA-6081: Fix test_basic_filters runtime profile failure ...................................................................... IMPALA-6081: Fix test_basic_filters runtime profile failure test_basic_filters has been occasionally failing due to a line missing from a runtime profile for a particular query. The problem is that the query returns all of its results before all of its backends are finished executing (due to a limit) causing the backends to be cancelled. Sometimes this cancellation happens quickly enough that the relevant fragment instances have not yet sent a status report when they are cancelled. They will still send a report in finalize, but as the coordinator only updates its runtime profile for 'ok' status reports, not 'cancelled', the final runtime profile doesn't end up with any data for those fragment instances, which means the test does not find the line in the runtime profile its checking for. The fix is to have the coordinator update its runtime profile with every status report it recieves, regardless of error status. Testing: - Ran existing runtime profile tests, which rely on profile output, in a loop. - Manually tested some scenarios with failed queries and checked that the new profile output is reasonable. Change-Id: I4f581c7c8039f02a33712515c5bffab942309bba --- M be/src/runtime/coordinator-backend-state.cc 1 file changed, 15 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/8754/1 -- To view, visit http://gerrit.cloudera.org:8080/8754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4f581c7c8039f02a33712515c5bffab942309bba Gerrit-Change-Number: 8754 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
