Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8754 )
Change subject: IMPALA-6081: Fix test_basic_filters runtime profile failure ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8754/1/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/8754/1/be/src/runtime/coordinator-backend-state.cc@457 PS1, Line 457: profile_->Update(exec_status.profile); In QueryState::ReportExecStatusAux(), where we generate the TReportExecStatusParams/TFragmentInstanceExecStatus, there is a case where we might not fill in the profile: if (fis->profile() != nullptr) { fis->profile()->ToThrift(&instance_status.profile); instance_status.__isset.profile = true; } It isn't clear to me whether we ever would generate a TFragmentInstanceExecStatus without a profile. Looking through the code, I don't think so. profile() translates to runtime_state_->profile_. FragmentInstanceState sets runtime_state_ at the very beginning of Prepare(). The runtime state's profile_ is set in the RuntimeState constructor. I think we are ok. QueryState::ReportExecStatusAux() has this assert: DCHECK(fis == nullptr || fis->IsPrepared()); If fis is nullptr, then there is no TFragmentInstanceExecStatus. If it IsPrepared() is true, then I think the profile should be filled in. Maybe change the code in ReportExecStatusAux() to DCHECK that it has a profile? -- To view, visit http://gerrit.cloudera.org:8080/8754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f581c7c8039f02a33712515c5bffab942309bba Gerrit-Change-Number: 8754 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 05 Dec 2017 21:56:00 +0000 Gerrit-HasComments: Yes
