Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8754 )
Change subject: IMPALA-6081: Fix test_basic_filters runtime profile failure ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8754/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8754/1//COMMIT_MSG@13 PS1, Line 13: causing the : backends to be cancelled. > where is that cancellation initiated? I don't think we explicitly initializ Right, but if a single fis sends a status report and gets back a 'cancelled' status from the coordinator, then all of the fis for that backend will be cancelled. http://gerrit.cloudera.org:8080/#/c/8754/1//COMMIT_MSG@31 PS1, Line 31: the new profile output is reasonable. > were you able to reproduce the original issue? Yes. Its difficult to repro the exact test failure as the timing has to be just right, but its easy to repro the general issue of fis not appearing in the final profile and its clear from the test output that this was what was happening in the builds that broke. -- To view, visit http://gerrit.cloudera.org:8080/8754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f581c7c8039f02a33712515c5bffab942309bba Gerrit-Change-Number: 8754 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 05 Dec 2017 19:18:47 +0000 Gerrit-HasComments: Yes
