Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 )
Change subject: IMPALA-6245: Tolerate column indenting from Hive ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/8719/4/testdata/workloads/functional-query/queries/QueryTest/views-ddl.test File testdata/workloads/functional-query/queries/QueryTest/views-ddl.test: http://gerrit.cloudera.org:8080/#/c/8719/4/testdata/workloads/functional-query/queries/QueryTest/views-ddl.test@281 PS4, Line 281: ---- QUERY Move this and the query validation into Python as well. We don't want to have a dependency on a .test file producing something that is then later used in Python. Better to have the whole test including setup and validation self-contained in one place. http://gerrit.cloudera.org:8080/#/c/8719/4/testdata/workloads/functional-query/queries/QueryTest/views-ddl.test@289 PS4, Line 289: # Test that the plan respects the plan hints for shuffle and broadcast I suggest moving this into Python as well. Might want to use explain_level=0 to keep it short. http://gerrit.cloudera.org:8080/#/c/8719/4/testdata/workloads/functional-query/queries/QueryTest/views-ddl.test@327 PS4, Line 327: # Test querying the hinted view. Move into Python as well. -- To view, visit http://gerrit.cloudera.org:8080/8719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e53b1230520ca6e850af28078526e6627d69de Gerrit-Change-Number: 8719 Gerrit-PatchSet: 4 Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Wed, 06 Dec 2017 05:14:07 +0000 Gerrit-HasComments: Yes
