Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 )
Change subject: IMPALA-6245: Tolerate column indenting from Hive ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8719/5/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/8719/5/tests/metadata/test_ddl.py@353 PS5, Line 353: assert '\n'.join(plan.data) == \ Let's do contains and not include the first 4 expected lines since those might change for completely unrelated reasons and hunting down all changed explains is often hard. -- To view, visit http://gerrit.cloudera.org:8080/8719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e53b1230520ca6e850af28078526e6627d69de Gerrit-Change-Number: 8719 Gerrit-PatchSet: 5 Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Sat, 09 Dec 2017 00:07:26 +0000 Gerrit-HasComments: Yes
