Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 )
Change subject: IMPALA-6245: Tolerate column indenting from Hive ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/8719/4/testdata/workloads/functional-query/queries/QueryTest/views-ddl.test File testdata/workloads/functional-query/queries/QueryTest/views-ddl.test: http://gerrit.cloudera.org:8080/#/c/8719/4/testdata/workloads/functional-query/queries/QueryTest/views-ddl.test@281 PS4, Line 281: ---- QUERY > Move this and the query validation into Python as well. We don't want to ha Done http://gerrit.cloudera.org:8080/#/c/8719/4/testdata/workloads/functional-query/queries/QueryTest/views-ddl.test@289 PS4, Line 289: # Test that the plan respects the plan hints for shuffle and broadcast > I suggest moving this into Python as well. Might want to use explain_level= Done http://gerrit.cloudera.org:8080/#/c/8719/4/testdata/workloads/functional-query/queries/QueryTest/views-ddl.test@327 PS4, Line 327: # Test querying the hinted view. > Move into Python as well. Done http://gerrit.cloudera.org:8080/#/c/8719/1/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/8719/1/tests/common/test_result_verifier.py@100 PS1, Line 100: 'Number of columns returned > the number of column types: %s' % column_types Garbage, will post another diff -- To view, visit http://gerrit.cloudera.org:8080/8719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e53b1230520ca6e850af28078526e6627d69de Gerrit-Change-Number: 8719 Gerrit-PatchSet: 4 Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Dec 2017 23:47:02 +0000 Gerrit-HasComments: Yes