Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8541
Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module ...................................................................... IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module Currently, if an error is encountered during the creation of a handcrafted codegen method, then the resulting IR is left in an incomplete state. This patch ensures that all such IRs are cleaned up (method body is truncated) before the llvm module is finalized. Testing: Tested manually by executing the following query and inspecting the dump of the optimized llvm module. Change-Id: If975cfb3906482b36dd6ede32ca81de6fcee1d7f --- M be/src/codegen/llvm-codegen-test.cc M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/hdfs-text-scanner.cc 4 files changed, 50 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/8541/8 -- To view, visit http://gerrit.cloudera.org:8080/8541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If975cfb3906482b36dd6ede32ca81de6fcee1d7f Gerrit-Change-Number: 8541 Gerrit-PatchSet: 8 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>