Hello Michael Ho, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8541
to look at the new patch set (#10).
Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before
finalizing module
......................................................................
IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module
Currently, if an error is encountered during the creation of a
handcrafted codegen method, then the resulting IR is left in an
incomplete state. This patch ensures that all such IRs are cleaned up
(method body is truncated) before the llvm module is finalized.
Tested manually as follows:
- move the cleanup instructions before the instructions for printing
the unoptimized llvm module in LlvmCodeGen::FinalizeModule()
- run the following query:
select * from charTable A, charTable B
where A.charColumn = B.charColumn and A.charColumn = 'foo'
- inspect the dump of the unoptimized module and make sure the methods
'InsertRuntimeFilters' and 'FilterContextInsert' are not defined
Change-Id: If975cfb3906482b36dd6ede32ca81de6fcee1d7f
---
M be/src/codegen/llvm-codegen-test.cc
M be/src/codegen/llvm-codegen.cc
M be/src/codegen/llvm-codegen.h
M be/src/exec/hdfs-text-scanner.cc
4 files changed, 58 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/8541/10
--
To view, visit http://gerrit.cloudera.org:8080/8541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If975cfb3906482b36dd6ede32ca81de6fcee1d7f
Gerrit-Change-Number: 8541
Gerrit-PatchSet: 10
Gerrit-Owner: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
