Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 )
Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module ...................................................................... Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/8541/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8541/10//COMMIT_MSG@12 PS10, Line 12: (method body is truncated) > deleted from module ? Done http://gerrit.cloudera.org:8080/#/c/8541/10/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: http://gerrit.cloudera.org:8080/#/c/8541/10/be/src/codegen/llvm-codegen.h@374 PS10, Line 374: removed > deleted from the module Done http://gerrit.cloudera.org:8080/#/c/8541/10/be/src/codegen/llvm-codegen.h@374 PS10, Line 374: their function body > the functions Done http://gerrit.cloudera.org:8080/#/c/8541/10/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/8541/10/be/src/codegen/llvm-codegen.cc@658 PS10, Line 658: DCHECK( > nit: DCHECK_EQ() Done http://gerrit.cloudera.org:8080/#/c/8541/10/be/src/codegen/llvm-codegen.cc@771 PS10, Line 771: codegen_->handcrafted_functions_.push_back(fn); > Mind adding a comment on why we only add function to "handcrafted_functions Done http://gerrit.cloudera.org:8080/#/c/8541/10/be/src/codegen/llvm-codegen.cc@1059 PS10, Line 1059: deleting the function's body. > Is this still true ? Done http://gerrit.cloudera.org:8080/#/c/8541/10/be/src/codegen/llvm-codegen.cc@1062 PS10, Line 1062: fn->eraseFromParent(); > I assume this should not happen very often so is it worth logging to aid de Done -- To view, visit http://gerrit.cloudera.org:8080/8541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If975cfb3906482b36dd6ede32ca81de6fcee1d7f Gerrit-Change-Number: 8541 Gerrit-PatchSet: 10 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Dec 2017 00:54:58 +0000 Gerrit-HasComments: Yes
