Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 )
Change subject: IMPALA-2640: Make a given command case-sensitive ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/8762/6/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/8762/6/shell/impala_shell.py@303 PS6, Line 303: beewax > spelling issue: it's beeswax, not beewax Done http://gerrit.cloudera.org:8080/#/c/8762/6/shell/impala_shell.py@551 PS6, Line 551: This may be overridden, but should not normally need to be; : see the precmd() and postcmd() methods for useful execution hooks. : The return value is a flag indicating whether interpretation of : commands by the interpreter should stop. > This comment shouldn't be here Removed the method. http://gerrit.cloudera.org:8080/#/c/8762/6/shell/impala_shell.py@572 PS6, Line 572: return func(arg, cmd_) > To me it looks a bit weird to pass the command string to each command. Done. -- To view, visit http://gerrit.cloudera.org:8080/8762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdce9781d1d97596c188691b62a141b9bd137610 Gerrit-Change-Number: 8762 Gerrit-PatchSet: 6 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Andre Araujo <ara...@cloudera.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Dec 2017 02:11:05 +0000 Gerrit-HasComments: Yes
