Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 )
Change subject: IMPALA-2640: Make a given command case-sensitive ...................................................................... Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/8762/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8762/6//COMMIT_MSG@7 PS6, Line 7: IMPALA-2640: Make a given command case-sensitive In the fix of IMPALA-4664(https://gerrit.cloudera.org/#/c/8639/4/shell/impala_shell.py), you thought a right fix is to hack code for lower-casting. I think this change for IMPALA-2640 can solve the lower-casting problem properly. The result of your example looks fine to me. Would you let me know what the problem is in the example? I guess the lowering of column description is intended, right? > sElEcT 'FoOoOo'; Query: select 'FoOoOo' Query submitted at: 2017-12-13 22:52:08 (Coordinator: http://ubuntu:25000) Query progress can be monitored at: http://ubuntu:25000/query_plan?query_id=20454e49cb053379:538981e900000000 +----------+ | 'fooooo' | +----------+ | FoOoOo | +----------+ http://gerrit.cloudera.org:8080/#/c/8762/6/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/8762/6/shell/impala_shell.py@572 PS6, Line 572: # is necessary to find > To me it looks a bit weird to pass the command string to each command. I think this intention, passing the command, is still valid for me. do_* methods are always not invoked here. See https://github.com/apache/impala/blob/master/shell/impala_shell.py#L208 Due to the above case, we should We may get the original command from http://gerrit.cloudera.org:8080/#/c/8762/9/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/8762/9/shell/impala_shell.py@305 PS9, Line 305: """Original command should be stored before running the method. The method is usually > Long line Done http://gerrit.cloudera.org:8080/#/c/8762/9/shell/impala_shell.py@310 PS9, Line 310: print_to_stderr("Unexpected error: Failed to execute query due to command "\ > Long line. Done http://gerrit.cloudera.org:8080/#/c/8762/9/shell/impala_shell.py@555 PS9, Line 555: > Can you include attribution for where the copied code came from (e.g. see b I added some comment for the coping. The PSF license is already included in LICENSE.txt. http://gerrit.cloudera.org:8080/#/c/8762/9/shell/impala_shell.py@571 PS9, Line 571: ne c > _ on the end of a local variable is a bit weird to me - can we call it comm Done -- To view, visit http://gerrit.cloudera.org:8080/8762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdce9781d1d97596c188691b62a141b9bd137610 Gerrit-Change-Number: 8762 Gerrit-PatchSet: 10 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Andre Araujo <ara...@cloudera.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Dec 2017 14:20:19 +0000 Gerrit-HasComments: Yes
