Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 )
Change subject: IMPALA-2640: Make a given command case-sensitive ...................................................................... Patch Set 8: (1 comment) Thanks for reacting so quickly. I also had a comment about testing in my previous reply. I wrote it as an inline comment this time. http://gerrit.cloudera.org:8080/#/c/8762/8/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/8762/8/tests/shell/test_shell_interactive.py@402 PS8, Line 402: select \"second command\"; Note that "select \"second command\";" is also unnecessary here. One more thing, could you add some tests where the commands are not sourced, but issued by ImpalaShell.send_cmd() ? -- To view, visit http://gerrit.cloudera.org:8080/8762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdce9781d1d97596c188691b62a141b9bd137610 Gerrit-Change-Number: 8762 Gerrit-PatchSet: 8 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Andre Araujo <ara...@cloudera.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Dec 2017 11:35:14 +0000 Gerrit-HasComments: Yes
