Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 )
Change subject: IMPALA-5754: Improve randomness of rand()/random() ...................................................................... Patch Set 17: (1 comment) > Fixed. Build failure happened due to missing license information at > rat_exclude_files.txt. > > 22:45:02 + bin/check-rat-report.py bin/rat_exclude_files.txt > rat.xml > > 22:45:02 NO APPROVALS; notice: be/src/thirdparty/pcg-cpp-0.98/LICENSE.txt > > 22:45:02 UNAPPROVED: be/src/thirdparty/pcg-cpp-0.98/README.md If you look at the bottom of the job output, it says "There were some failed jobs" and points to two failed jobs. http://gerrit.cloudera.org:8080/#/c/8355/17/bin/rat_exclude_files.txt File bin/rat_exclude_files.txt: http://gerrit.cloudera.org:8080/#/c/8355/17/bin/rat_exclude_files.txt@142 PS17, Line 142: be/src/thirdparty/pcg-cpp-0.98/README.md the README is not a notice called out in /LICENSE.txt. There is a section for READMEs up above. -- To view, visit http://gerrit.cloudera.org:8080/8355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idafdd5fe7502ff242c76a91a815c565146108684 Gerrit-Change-Number: 8355 Gerrit-PatchSet: 17 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Mon, 11 Dec 2017 16:42:48 +0000 Gerrit-HasComments: Yes
