Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 )
Change subject: IMPALA-5754: Improve randomness of rand()/random() ...................................................................... Patch Set 19: > (1 comment) > > > Fixed. Build failure happened due to missing license information > at > > rat_exclude_files.txt. > > > 22:45:02 + bin/check-rat-report.py bin/rat_exclude_files.txt > > rat.xml > > > 22:45:02 NO APPROVALS; notice: be/src/thirdparty/pcg-cpp-0.98/LICENSE.txt > > > 22:45:02 UNAPPROVED: be/src/thirdparty/pcg-cpp-0.98/README.md > > If you look at the bottom of the job output, it says "There were > some failed jobs" and points to two failed jobs. I think you may have missed this comment. There were two failed jobs. You have addressed one of them - thank you! Can you take a look at the other one? -- To view, visit http://gerrit.cloudera.org:8080/8355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idafdd5fe7502ff242c76a91a815c565146108684 Gerrit-Change-Number: 8355 Gerrit-PatchSet: 19 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Tue, 12 Dec 2017 17:41:54 +0000 Gerrit-HasComments: No
