Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8355 )
Change subject: IMPALA-5754: Improve randomness of rand()/random() ...................................................................... IMPALA-5754: Improve randomness of rand()/random() Currently implementation of rand/random built-in functions use rand_r of C library. We recognized its randomness was poor. pcg32 of third party library shows better randomness than rand_r. Testing: Revise unit test in expr-test Add E2E test to random.test Change-Id: Idafdd5fe7502ff242c76a91a815c565146108684 Reviewed-on: http://gerrit.cloudera.org:8080/8355 Reviewed-by: Jim Apple <[email protected]> Tested-by: Impala Public Jenkins --- M LICENSE.txt M be/src/exprs/expr-test.cc M be/src/exprs/math-functions-ir.cc A be/src/thirdparty/pcg-cpp-0.98/LICENSE.txt A be/src/thirdparty/pcg-cpp-0.98/README.md A be/src/thirdparty/pcg-cpp-0.98/include/pcg_extras.hpp A be/src/thirdparty/pcg-cpp-0.98/include/pcg_random.hpp A be/src/thirdparty/pcg-cpp-0.98/include/pcg_uint128.hpp M bin/rat_exclude_files.txt M bin/run_clang_tidy.sh M testdata/workloads/functional-query/queries/QueryTest/alloc-fail-init.test A testdata/workloads/functional-query/queries/QueryTest/random.test M tests/query_test/test_queries.py 13 files changed, 3,458 insertions(+), 32 deletions(-) Approvals: Jim Apple: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idafdd5fe7502ff242c76a91a815c565146108684 Gerrit-Change-Number: 8355 Gerrit-PatchSet: 22 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]>
