Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 )
Change subject: IMPALA-6245: Tolerate column indenting from Hive ...................................................................... Patch Set 7: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8719/7/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/8719/7/tests/metadata/test_ddl.py@362 PS7, Line 362: 00:SCAN HDFS [functional.alltypestiny a]""" in '\n'.join(plan.data) > I think you meant this? Works for me. My primary concern is with sprinkling expected explain plans in various tests. That makes it really hard to change anything in the planner because "random" unrelated tests can fail. So when checking plans we should minimize the ways in which planner changes can break it. -- To view, visit http://gerrit.cloudera.org:8080/8719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e53b1230520ca6e850af28078526e6627d69de Gerrit-Change-Number: 8719 Gerrit-PatchSet: 7 Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Mon, 11 Dec 2017 19:18:31 +0000 Gerrit-HasComments: Yes
