Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 )
Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. ...................................................................... Patch Set 3: (3 comments) Thanks for the comments. Please have a look at patch set #4. http://gerrit.cloudera.org:8080/#/c/8784/3/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/8784/3/tests/common/impala_service.py@64 PS3, Line 64: def get_thrift_profile(self, query_id, timeout=10, interval=1): > please add pydoc. This will get used again, I'm sure. Done http://gerrit.cloudera.org:8080/#/c/8784/3/tests/common/impala_service.py@73 PS3, Line 73: LOG.info("Thrift profile for query %s not yet available.") > Is there a more specific exception you can use? Alternately, put the try/ex Great suggestions! I now have two try/except blocks: one for open_debug_webpage(), and another for deserialize() and its callees. Changed the function to return None on failure. http://gerrit.cloudera.org:8080/#/c/8784/3/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/8784/3/tests/query_test/test_observability.py@125 PS3, Line 125: service = ImpalaCluster().get_first_impalad().service > I think this maybe should be self.impalad_test_service it is. -- To view, visit http://gerrit.cloudera.org:8080/8784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3421a34cc029ebca551730084c7cbd402d5c109 Gerrit-Change-Number: 8784 Gerrit-PatchSet: 3 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Tue, 12 Dec 2017 06:28:10 +0000 Gerrit-HasComments: Yes
