Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 )
Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. ...................................................................... Patch Set 4: (3 comments) Thanks for the comments. Uploading patch set #5. http://gerrit.cloudera.org:8080/#/c/8784/4/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/8784/4/tests/common/impala_service.py@70 PS4, Line 70: LOG.info("Thrift profile for query %s not yet available: %s", query_id, str(e)) > This is really esoteric, but you can get python to print the exception by p Thanks for the information :) http://gerrit.cloudera.org:8080/#/c/8784/4/tests/common/impala_service.py@81 PS4, Line 81: return None > I don't think this should return None. It's not expected that we can't dese I've seen this fail like below: $ ./run-tests.py -k test_query_profile_thrift_timestamps query_test/test_observability.py $ cat $IMPALA_HOME/logs/ee_tests/results/TEST-impala-verify-metrics.xml .... -- fetching results from: <tests.common.impala_connection.OperationHandle object at 0x7fad2b6ac390> -- closing connection to: localhost:21000 MainThread: Exception while deserializing query profile of 745d01f212903da:243a23c600000000: Incorrect padding .... Sometimes I've seen it raise exception 3 times before finally succeeding in retrieving a valid thrift profile. This being an "API" I'd like to return None here, and let the caller deal with that. http://gerrit.cloudera.org:8080/#/c/8784/4/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/8784/4/tests/query_test/test_observability.py@155 PS4, Line 155: dbg_str = 'Debug thrift profile for query %s' + str(query_id) + ' not available in ' > I don't think that %s is interpolated. Thanks for catching that! Fixed. -- To view, visit http://gerrit.cloudera.org:8080/8784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3421a34cc029ebca551730084c7cbd402d5c109 Gerrit-Change-Number: 8784 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Dec 2017 00:08:43 +0000 Gerrit-HasComments: Yes