Zoram Thanga has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8784 )

Change subject: IMPALA-6225: Part 2: Query profile date-time strings should 
have ns precision.
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8784/4/tests/common/impala_service.py
File tests/common/impala_service.py:

http://gerrit.cloudera.org:8080/#/c/8784/4/tests/common/impala_service.py@81
PS4, Line 81:         return None
> This smells like a bug to me. Are we returning something invalid?
Umm...I should have been clearer on this. It's the Impala server returning 
something like this:

Query id c64d6312b0ff892f:5b3d746400000000 not found.

The same thing is logged as

I1214 11:09:44.728435 24686 impala-server.cc:642] Query id 
c64d6312b0ff892f:5b3d746400000000 not found.

When this happens, our tbuf contains the following:

Could not obtain runtime profile: Query id c64d6312b0ff892f:5b3d746400000000 
not found.

I don't know if that should count as a bug. It seems to me like it takes 
sometime for the runtime profile to propagate into the query map and/or query 
log. Again, I don't see this issue if I don't use "-k 
test_query_profile_thrift_timestamps".



--
To view, visit http://gerrit.cloudera.org:8080/8784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3421a34cc029ebca551730084c7cbd402d5c109
Gerrit-Change-Number: 8784
Gerrit-PatchSet: 5
Gerrit-Owner: Zoram Thanga <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Zoram Thanga <[email protected]>
Gerrit-Comment-Date: Thu, 14 Dec 2017 19:24:56 +0000
Gerrit-HasComments: Yes

Reply via email to