Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 )
Change subject: IMPALA-2640: Make a given command case-sensitive ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/8762/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8762/6//COMMIT_MSG@7 PS6, Line 7: IMPALA-2640: Make a given command case-sensitive > In the fix of IMPALA-4664(https://gerrit.cloudera.org/#/c/8639/4/shell/impa I think the lower-case column description is intended. The tests you added in https://gerrit.cloudera.org/#/c/8639/4/tests/shell/test_shell_interactive.py all appear to be fixed by this patch set, so I think we should add those tests to this patch. http://gerrit.cloudera.org:8080/#/c/8762/9/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/8762/9/shell/impala_shell.py@555 PS9, Line 555: > I added some comment for the coping. The PSF license is already included in We still need to add a line in LICENSE.txt like: Parts of shell/impala_shell.py: Python Software License V2 -- To view, visit http://gerrit.cloudera.org:8080/8762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdce9781d1d97596c188691b62a141b9bd137610 Gerrit-Change-Number: 8762 Gerrit-PatchSet: 6 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Andre Araujo <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 13 Dec 2017 23:09:45 +0000 Gerrit-HasComments: Yes
