Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 )
Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. ...................................................................... Patch Set 6: (1 comment) Thanks for the comments. Please see #7 http://gerrit.cloudera.org:8080/#/c/8784/6/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/8784/6/tests/query_test/test_observability.py@156 PS6, Line 156: tree.validate() > Just for my own knowledge: where is validate() defined ? This is defined in shell/gen-py/RuntimeProfile/ttypes.py If validate() fails it raises a TProtocolException. The validation is very minimal, actually. Will move it to get_thrift_profile(). -- To view, visit http://gerrit.cloudera.org:8080/8784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3421a34cc029ebca551730084c7cbd402d5c109 Gerrit-Change-Number: 8784 Gerrit-PatchSet: 6 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Dec 2017 00:08:24 +0000 Gerrit-HasComments: Yes
