Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 )
Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8784/6/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/8784/6/tests/query_test/test_observability.py@156 PS6, Line 156: tree.validate() > Just for my own knowledge: where is validate() defined ? validate() is defined in the generated code. https://github.com/apache/thrift/blob/041c3c777db9639b0a9195bc6aa1f935501fd506/compiler/cpp/src/thrift/generate/t_py_generator.cc#L1059 is the generator Here's an example of generated code: def validate(self): if self.principalGrants is None: raise TProtocol.TProtocolException(message='Required field principalGrants is unset!') return Note that most validate() implementations are empty; I think they only get generated for required fields. I think you can reasonably move it to get_thrift_profile(). -- To view, visit http://gerrit.cloudera.org:8080/8784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3421a34cc029ebca551730084c7cbd402d5c109 Gerrit-Change-Number: 8784 Gerrit-PatchSet: 6 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Wed, 20 Dec 2017 23:49:18 +0000 Gerrit-HasComments: Yes
