Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 )
Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8784/6/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/8784/6/tests/query_test/test_observability.py@156 PS6, Line 156: tree.validate() Just for my own knowledge: where is validate() defined ? Also, what would happen if validation fails ? Should this actually belong to get_thrift_profile() ? -- To view, visit http://gerrit.cloudera.org:8080/8784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3421a34cc029ebca551730084c7cbd402d5c109 Gerrit-Change-Number: 8784 Gerrit-PatchSet: 6 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Wed, 20 Dec 2017 23:07:40 +0000 Gerrit-HasComments: Yes
