Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8929
Change subject: IMPALA-6355: fix overflow DCHECK in decimal mod ...................................................................... IMPALA-6355: fix overflow DCHECK in decimal mod The bug is that ConvertToInt128(), by design, only sets 'overflow' if an overflow occurs. This means that caller needs to initialise the overflow variable to false, otherwise the value when overflow occurs is undefined. Testing: Reprod the expr-test failure under ASAN, confirmed that it passed after this fix. Change-Id: Ifd7ac691155442ba7cba71dd3647208b7c1c0bf9 --- M be/src/runtime/decimal-value.inline.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/8929/1 -- To view, visit http://gerrit.cloudera.org:8080/8929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd7ac691155442ba7cba71dd3647208b7c1c0bf9 Gerrit-Change-Number: 8929 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]>
