Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8929 )
Change subject: IMPALA-6355: fix overflow DCHECK in decimal mod ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8929/1/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: http://gerrit.cloudera.org:8080/#/c/8929/1/be/src/runtime/decimal-value.inline.h@571 PS1, Line 571: DCHECK(!ovf) is overflow here a valid case? if yes, should we return it in '*overflow' instead of DCHECKing ? -- To view, visit http://gerrit.cloudera.org:8080/8929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd7ac691155442ba7cba71dd3647208b7c1c0bf9 Gerrit-Change-Number: 8929 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Wed, 03 Jan 2018 20:11:40 +0000 Gerrit-HasComments: Yes
