Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8929 )
Change subject: IMPALA-6355: fix overflow DCHECK in decimal mod ...................................................................... IMPALA-6355: fix overflow DCHECK in decimal mod The bug is that ConvertToInt128(), by design, only sets 'overflow' if an overflow occurs. This means that caller needs to initialise the overflow variable to false, otherwise the value when overflow occurs is undefined. Testing: Reprod the expr-test failure under ASAN, confirmed that it passed after this fix. Change-Id: Ifd7ac691155442ba7cba71dd3647208b7c1c0bf9 Reviewed-on: http://gerrit.cloudera.org:8080/8929 Reviewed-by: Bikramjeet Vig <[email protected]> Reviewed-by: Michael Brown <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/runtime/decimal-value.inline.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Bikramjeet Vig: Looks good to me, but someone else must approve Michael Brown: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifd7ac691155442ba7cba71dd3647208b7c1c0bf9 Gerrit-Change-Number: 8929 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
