Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 )
Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command ...................................................................... Patch Set 9: (3 comments) Applied changes. http://gerrit.cloudera.org:8080/#/c/8928/8/fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java: http://gerrit.cloudera.org:8080/#/c/8928/8/fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java@72 PS8, Line 72: throw new AnalysisException(String.format("ALTER TABLE SET ROW FORMAT is " + > The new analyzer tests don't cover this scenario, please add a test. You ca Done http://gerrit.cloudera.org:8080/#/c/8928/8/fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java@73 PS8, Line 73: "only supported on TEXT or SEQUENCE file formats. " + > Let's add a sentence "Conflicting partition: " + name and include the forma Done http://gerrit.cloudera.org:8080/#/c/8928/8/fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java@82 PS8, Line 82: if (format != HdfsFileFormat.TEXT && > let's include the format of the table Done -- To view, visit http://gerrit.cloudera.org:8080/8928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96e347463504915a6f33932552e4d1f61e9b1154 Gerrit-Change-Number: 8928 Gerrit-PatchSet: 9 Gerrit-Owner: Adam Holley <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Comment-Date: Fri, 12 Jan 2018 17:03:19 +0000 Gerrit-HasComments: Yes
