Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 )
Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command ...................................................................... Patch Set 8: (3 comments) Almost there http://gerrit.cloudera.org:8080/#/c/8928/8/fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java: http://gerrit.cloudera.org:8080/#/c/8928/8/fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java@72 PS8, Line 72: throw new AnalysisException("ALTER TABLE SET ROW FORMAT is only supported " + The new analyzer tests don't cover this scenario, please add a test. You can use functional.alltypesmixedformat. http://gerrit.cloudera.org:8080/#/c/8928/8/fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java@73 PS8, Line 73: "on TEXT or SEQUENCE file formats: " + partition.getPartitionName()); Let's add a sentence "Conflicting partition: " + name and include the format of the partition otherwise it's not obvious what the partition name means http://gerrit.cloudera.org:8080/#/c/8928/8/fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java@82 PS8, Line 82: "on TEXT or SEQUENCE file formats: " + tbl.getFullName()); let's include the format of the table -- To view, visit http://gerrit.cloudera.org:8080/8928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96e347463504915a6f33932552e4d1f61e9b1154 Gerrit-Change-Number: 8928 Gerrit-PatchSet: 8 Gerrit-Owner: Adam Holley <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Comment-Date: Thu, 11 Jan 2018 20:53:27 +0000 Gerrit-HasComments: Yes
