Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9002 )
Change subject: IMPALA-6383: free memory after skipping parquet row groups ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/9002/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9002/1//COMMIT_MSG@13 PS1, Line 13: Testing: > My feeling is that this testing is enough for now. With the reservation cha Sounds good, thanks for the clarification. http://gerrit.cloudera.org:8080/#/c/9002/1/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/9002/1/be/src/exec/hdfs-parquet-scanner.cc@623 PS1, Line 623: // We skipped the previous row group. Release resources before starting another. > I could also reorganise the code so that ReleaseSkippedRowGroupResources() I thought about that, too, but I like that the current structure makes it less likely to forget adding it. If the call is check we could leave it as is. I don't feel strongly about it. -- To view, visit http://gerrit.cloudera.org:8080/9002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc2f8f27c9b238be60261539f8d4be2facb57a2b Gerrit-Change-Number: 9002 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 12 Jan 2018 12:01:56 +0000 Gerrit-HasComments: Yes
