Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9002 )
Change subject: IMPALA-6383: free memory after skipping parquet row groups ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9002/4/be/src/exec/hdfs-parquet-scanner.h File be/src/exec/hdfs-parquet-scanner.h: http://gerrit.cloudera.org:8080/#/c/9002/4/be/src/exec/hdfs-parquet-scanner.h@647 PS4, Line 647: /// were returned and when returning the last batch. What does the last part about "when returning the last batch mean"? Isn't that what FlushRowGroupResources() is for? -- To view, visit http://gerrit.cloudera.org:8080/9002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc2f8f27c9b238be60261539f8d4be2facb57a2b Gerrit-Change-Number: 9002 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 12 Jan 2018 21:26:57 +0000 Gerrit-HasComments: Yes
