Hello Michael Ho, Lars Volker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9002
to look at the new patch set (#3).
Change subject: IMPALA-6383: free memory after skipping parquet row groups
......................................................................
IMPALA-6383: free memory after skipping parquet row groups
Before this patch, resources were only flushed after breaking out of
NextRowGroup(). This is a problem because resources can be allocated
for skipped row groups (e.g. for reading dictionaries).
Testing:
Tested in conjunction with a prototype buffer pool patch that was
DCHECKing before the change.
Added DCHECKs to the current version to ensure the streams are cleared
up as expected.
Change-Id: Ibc2f8f27c9b238be60261539f8d4be2facb57a2b
---
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/exec/hdfs-parquet-scanner.h
M be/src/exec/scanner-context.h
3 files changed, 30 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/9002/3
--
To view, visit http://gerrit.cloudera.org:8080/9002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc2f8f27c9b238be60261539f8d4be2facb57a2b
Gerrit-Change-Number: 9002
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>