Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8973 )
Change subject: IMPALA-4315: Allow USE and SHOW TABLES if the user has only column privileges ...................................................................... Patch Set 1: I think we should extend AuthorizationTest#TestUseDb() which means adding a Db with only column level privileges. Why do you say that change is more complex? To me it's cognitively more complex and less organized to have some parts of "USE <db>" authorization tested in grant_revoke.test and some parts tested in AuthorizationTest#TestUseDb(). I think they all belong in AuthorizationTest#TestUseDb(). -- To view, visit http://gerrit.cloudera.org:8080/8973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69756a18cb1db304d2bb8c92288612cbd1164d8 Gerrit-Change-Number: 8973 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Sat, 13 Jan 2018 00:23:56 +0000 Gerrit-HasComments: No
