Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8973 )
Change subject: IMPALA-4315: Allow USE and SHOW TABLES if the user has only column privileges ...................................................................... Patch Set 3: > > Dimitris, what is your opinion about the best place for these > > tests? Should it be AuthorizationTest.java, or grant_revoke.test, > > or both? Adding them to AuthorizationTest.java would mean that > one > > of the common databases should be set up to contain only column > > privileges. > > I prefer the AuthorizationTest.java (tests TestUseDb and > TestShowTable..., for this patch) even if that means expanding our > initial auth setup. Feel free to pick any database not currently > used by these tests. Don't forget to modify the authz-policy.ini I have moved the tests to > > Dimitris, what is your opinion about the best place for these > > tests? Should it be AuthorizationTest.java, or grant_revoke.test, > > or both? Adding them to AuthorizationTest.java would mean that > one > > of the common databases should be set up to contain only column > > privileges. > > I prefer the AuthorizationTest.java (tests TestUseDb and > TestShowTable..., for this patch) even if that means expanding our > initial auth setup. Feel free to pick any database not currently > used by these tests. Don't forget to modify the authz-policy.ini I have moved the tests to AuthorizationTest.java. About authz-policy.ini: I copied the changed file to hdfs manually. Shouldn't one of the build or test steps detect the change, and update this file? -- To view, visit http://gerrit.cloudera.org:8080/8973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69756a18cb1db304d2bb8c92288612cbd1164d8 Gerrit-Change-Number: 8973 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Tue, 16 Jan 2018 19:11:09 +0000 Gerrit-HasComments: No
