Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8973 )
Change subject: IMPALA-4315: Allow USE and SHOW TABLES if the user has only column privileges ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/8973/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/8973/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@102 PS3, Line 102: // SELECT permissions on columns ('id') on 'functional_avro.alltypessmall' > missing opening single-quote for 'functional_avro.alltypessmall' Done http://gerrit.cloudera.org:8080/#/c/8973/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@399 PS3, Line 399: privilege = new TPrivilege("", TPrivilegeLevel.SELECT, > typo: privilege (which has already been declared) Thanks for spotting it! Please ignore patch set 4, and compare 3 to 5. Note that it may look like if this could fit into 1 line, but it would be 91 characters. -- To view, visit http://gerrit.cloudera.org:8080/8973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69756a18cb1db304d2bb8c92288612cbd1164d8 Gerrit-Change-Number: 8973 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Wed, 17 Jan 2018 13:34:55 +0000 Gerrit-HasComments: Yes
